Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use comfyui 7df42b9a #308

Merged
merged 3 commits into from
Aug 23, 2024
Merged

feat: use comfyui 7df42b9a #308

merged 3 commits into from
Aug 23, 2024

Conversation

tazlin
Copy link
Member

@tazlin tazlin commented Aug 23, 2024

tazlin added 3 commits August 23, 2024 13:29
In comfyui internals, 'prompt` actually refers to an entire set of nodes and settings. Previously, we were hijacking the `recursive_output_delete_if_changed` call, but a recent change in comfyui has switched this behavior to the class `IsChangedCache`. The hook in place before had more to do with detecting bugs to do with caching than anything else, so I've implemented a similar sort of hijack for `IsChangedCache`.
The presence of the key `output` in `data` during `send_sync` calls was enough to assert `data["output"]["images"]` was present and populated (i.e., we are post-inference and receiving the final images from comfyui). However, comfyui internals have changed so that `data["output"]["images"]` can be equal to `None` in ordinary circumstances during other stages of generation. As such, I have changed the logic to check for the key and for non-`None` values.
@tazlin tazlin merged commit 55139fc into main Aug 23, 2024
2 checks passed
@tazlin tazlin deleted the comfyui-7df42b9a branch August 23, 2024 22:01
@tazlin tazlin mentioned this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant